lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] w1-gpio: Simplify & get rid of defines
Hi

On Wed, Oct 31, 2012 at 05:57:44PM +0200, Pantelis Antoniou (panto@antoniou-consulting.com) wrote:
> There's no reason to have the OF defines; it complicates the driver.
> There's also no need for the funky platform_driver_probe.
>
> Add a few warnings in case there's a failure; helps us find out
> what went wrong.
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>

Looks good to me, but I'm hardly an expert in omap platform.
Feel free to add my ack, but please submit this patch through
appropriate tree.
Thank you.

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

--
Evgeniy Polyakov


\
 
 \ /
  Last update: 2012-11-05 17:21    [W:0.045 / U:1.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site