Messages in this thread | | | Date | Mon, 5 Nov 2012 19:47:45 +0400 | From | Evgeniy Polyakov <> | Subject | Re: [PATCH] w1-gpio: Simplify & get rid of defines |
| |
Hi
On Wed, Oct 31, 2012 at 05:57:44PM +0200, Pantelis Antoniou (panto@antoniou-consulting.com) wrote: > There's no reason to have the OF defines; it complicates the driver. > There's also no need for the funky platform_driver_probe. > > Add a few warnings in case there's a failure; helps us find out > what went wrong. > > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
Looks good to me, but I'm hardly an expert in omap platform. Feel free to add my ack, but please submit this patch through appropriate tree. Thank you.
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
-- Evgeniy Polyakov
| |