lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] power: battery: pointer math issue in gab_probe()
From
Date
Hello Dan,

Is this patch of yours picked up by anyone?
On Sun, 2012-09-30 at 09:38 +0530, anish kumar wrote:
> On Sat, 2012-09-29 at 10:13 +0300, Dan Carpenter wrote:
> > psy->properties is an enum (32 bit type) so adding sizeof() puts us
> > four times further along than we intended. It should be cast to a char
> > pointer before doing the math.
> You really read this driver to find out this one.
> Good one.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Casting to void * would also work on GCC, at least.
> >
> > diff --git a/drivers/power/generic-adc-battery.c b/drivers/power/generic-adc-battery.c
> > index 9bdf444..776f118 100644
> > --- a/drivers/power/generic-adc-battery.c
> > +++ b/drivers/power/generic-adc-battery.c
> > @@ -279,7 +279,8 @@ static int __devinit gab_probe(struct platform_device *pdev)
> > }
> >
> > memcpy(psy->properties, gab_props, sizeof(gab_props));
> > - properties = psy->properties + sizeof(gab_props);
> > + properties = (enum power_supply_property *)
> > + ((char *)psy->properties + sizeof(gab_props));
> >
> > /*
> > * getting channel from iio and copying the battery properties
>




\
 
 \ /
  Last update: 2012-11-05 14:21    [W:0.116 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site