lkml.org 
[lkml]   [2012]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/14] perf diff: Change diff command to work over multiple data files
On Thu, Nov 29, 2012 at 08:37:50PM +0900, Namhyung Kim wrote:
> On Wed, 28 Nov 2012 14:52:43 +0100, Jiri Olsa wrote:
> > Adding diff command the flexibility to specify multiple data
> > files on input. If not input file is given the standard behaviour
> > stands and diff inspects 'perf.data' and 'perf.data.old' files.
> >
> > Also changing the processing and output display for data files.
> >
> > For 'perf diff A B' command:
> >
> > - the current way is to iterate over B data and display
> > A (baseline) data (symbol samples) only if found in B
> >
> > - this patch iterates over A (baseline) data and display
> > B data (symbol samples) only if found in A
> >
> > For 'perf diff A B C' command, the diff now iterates the
> > A (baseline) data and display B and C data (symbol samples)
> > only if they found in A (baseline)
> >
> > All other standard diff command computation features
> > (delta,ratio,wdiff) stays.
>
> This is quite a large change and IMHO can be separated into 3 patches at
> least.

you should have seen this patch before ;-)

>
> 1) change he->pairs from list to array

ok

> 2) introduce diff_data__fmt
> 3) convert to diff_data__fmt

will try ;)

thanks,
jirka


\
 
 \ /
  Last update: 2012-11-29 14:21    [W:0.044 / U:1.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site