lkml.org 
[lkml]   [2012]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sound/sgtl5000: fix initial setting for DAC data source
On Wed, Nov 28, 2012 at 10:14:28AM +0000, Oskar Schirmer wrote:

You've somehow decided to CC half the world but still haven't managed
to CC the maintainers like Liam asked (and as is covered in
SubmittingPatches)...

> According to documentation bit 3:2 in register SSS_CTRL are
> reserved and zero, so the setting of 0x0008 does not make much sense.
> Instead, bit 4 should be set as is with power up, to reflect
> routing of I2S_IN to DAC correctly.

> Looks much like an off by one error.

What does "as is with power up" mean? This is a register defaults
table, it should reflect what is in the register defaults. The meaning
of the field and the desired configuration for runtime is not relevant
here, the only thing that matters is what the default value of the
register is.


\
 
 \ /
  Last update: 2012-11-28 16:01    [W:0.044 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site