Messages in this thread | | | Date | Wed, 21 Nov 2012 07:26:00 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH 3/5] KVM: MMU: simplify set_spte |
| |
On 11/21/2012 06:24 AM, Marcelo Tosatti wrote: > On Mon, Nov 05, 2012 at 08:11:03PM +0800, Xiao Guangrong wrote: >> It is more cleaner if we can update pte_access fist then set spte according >> to pte_access, also introduce gfn_need_write_protect to check whether the >> gfn need to be write-protected >> >> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> > > Please separate patch in: > - code movement with no logical modification. > - logical modification (such as condition for mark_page_dirty). > - move code to helper functions.
Okay, will split it.
| |