lkml.org 
[lkml]   [2012]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] MODSIGN: Add modules_sign make target
Date
Josh Boyer <jwboyer@redhat.com> writes:

> On Thu, Nov 01, 2012 at 06:03:18PM +1030, Rusty Russell wrote:
>> Josh Boyer <jwboyer@redhat.com> writes:
>>
>> > If CONFIG_MODULE_SIG is set, and 'make modules_sign' is called then this
>> > patch will cause the modules to get a signature appended. The make target
>> > is intended to be run after 'make modules_install', and will modify the
>> > modules in-place in the installed location. It can be used to produce
>> > signed modules after they have been processed by distribution build
>> > scripts.
>> >
>> > Signed-off-by: Josh Boyer <jwboyer@redhat.com>
>>
>> It's a bit of a niche case, but applied.
>
> Thanks. Whether you consider RPM built kernels niche or not doesn't
> matter to me. Having this upstream is one less patch we have to carry
> so I appreciate it a lot.

My comment was more that this relies on eu-strip, because we always
sign modules on installation, so you need eu-strip to *unsign* them
(strip won't do it, BTW).

More general would be a modules_install_unsigned target to match this,
but since noone would use it, let's not write it :)

Cheers,
Rusty.


\
 
 \ /
  Last update: 2012-11-02 05:41    [W:2.889 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site