Messages in this thread | | | Date | Fri, 2 Nov 2012 22:49:45 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] IRQ CORE: irq_work_queue function return value not used. |
| |
On Fri, 2 Nov 2012, Steven Rostedt wrote:
> On Fri, 2012-11-02 at 22:24 +0900, anish kumar wrote: > > From: anish kumar <anish198519851985@gmail.com> > > > > As no one is using the return value of irq_work_queue function > > it is better to just make it void. > > Acked-by: Steven Rostedt <rostedt@goodmis.org> > > Peter, like to take this patch? Or is there a reason you have for > irq_work_queue() returning a value? > > -- Steve > > > Signed-off-by: anish kumar <anish198519851985@gmail.com> > > --- > > kernel/irq_work.c | 6 +++--- > > 1 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/kernel/irq_work.c b/kernel/irq_work.c > > index 1588e3b..a85c4b3 100644 > > --- a/kernel/irq_work.c > > +++ b/kernel/irq_work.c > > @@ -79,17 +79,17 @@ static void __irq_work_queue(struct irq_work *work) > > * > > * Can be re-enqueued while the callback is still in progress. > > */ > > -bool irq_work_queue(struct irq_work *work) > > +void irq_work_queue(struct irq_work *work) > > { > > if (!irq_work_claim(work)) { > > /* > > * Already enqueued, can't do! > > */ > > - return false; > > + return; > > } > > > > __irq_work_queue(work); > > - return true; > > + return;
And while at it please zap that pointless "return;" statement.
> > } > > EXPORT_SYMBOL_GPL(irq_work_queue); > > > > >
| |