Messages in this thread Patch in this message | | | From | Naoya Horiguchi <> | Subject | [PATCH 2/2 v2] mm: print out information of file affected by memory error | Date | Fri, 2 Nov 2012 12:33:13 -0400 |
| |
Printing out the information about which file can be affected by a memory error in generic_error_remove_page() is helpful for user to estimate the impact of the error.
Changelog v2: - dereference mapping->host after if (!mapping) check for robustness
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Cc: Jan Kara <jack@suse.cz> --- mm/truncate.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git v3.7-rc3.orig/mm/truncate.c v3.7-rc3/mm/truncate.c index d51ce92..db1b216 100644 --- v3.7-rc3.orig/mm/truncate.c +++ v3.7-rc3/mm/truncate.c @@ -151,14 +151,20 @@ int truncate_inode_page(struct address_space *mapping, struct page *page) */ int generic_error_remove_page(struct address_space *mapping, struct page *page) { + struct inode *inode; + if (!mapping) return -EINVAL; + inode = mapping->host; /* * Only punch for normal data pages for now. * Handling other types like directories would need more auditing. */ - if (!S_ISREG(mapping->host->i_mode)) + if (!S_ISREG(inode->i_mode)) return -EIO; + pr_info("MCE %#lx: file info pgoff:%lu, inode:%lu, dev:%s\n", + page_to_pfn(page), page_index(page), + inode->i_ino, inode->i_sb->s_id); return truncate_inode_page(mapping, page); } EXPORT_SYMBOL(generic_error_remove_page); -- 1.7.11.7
| |