lkml.org 
[lkml]   [2012]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/9] pstore: add task list dumper
On Thu, Oct 18, 2012 at 02:06:03PM +0300, dragos.tatulea@intel.com wrote:
> From: Dragos Tatulea <dragos.tatulea@intel.com>
>
> The task dumper can dump task information during a panic.
> This is equivalent to a magic sysrq 't' command but
> the result is captured from the console and written
> to persistent storage. Note that this happens after
> pstore dumps kernel messages because the task dump will
> overwrite other kernel messages.
>
> There is a single module parameter "enabled" which must
> be used to enable task dumping.

This is a very very strange approach to accomplish this.

Plus, we have the console dumper already, so I think it should be done the
other way around: if you want a tasklist dumped during panic, introduce a
generic feature for the panic logging, i.e. just print tasks after/before
panic trace.

Or am I missing the point of the patch?

>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Dragos Tatulea <dragos.tatulea@intel.com>
> ---
> fs/pstore/Kconfig | 12 ++++++
> fs/pstore/Makefile | 1 +
> fs/pstore/dump_tasks.c | 107 ++++++++++++++++++++++++++++++++++++++++++++++++
> fs/pstore/inode.c | 3 ++
> include/linux/pstore.h | 1 +
> 5 files changed, 124 insertions(+)
> create mode 100644 fs/pstore/dump_tasks.c
>
> diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
> index ca71db6..ee967c5 100644
> --- a/fs/pstore/Kconfig
> +++ b/fs/pstore/Kconfig
> @@ -48,3 +48,15 @@ config PSTORE_RAM
> "ramoops.ko".
>
> For more information, see Documentation/ramoops.txt.
> +
> +config PSTORE_DUMP_TASKS
> + bool "Dump task information"
> + default n

'default n' is there by default. :) So no need for this line.

Thanks,
Anton.


\
 
 \ /
  Last update: 2012-11-18 04:21    [W:0.077 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site