lkml.org 
[lkml]   [2012]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 1/7] procfs: Add ability to plug in auxiliary fdinfo providers
    On Mon, Nov 12, 2012 at 04:40:22PM -0800, Andrew Morton wrote:
    > >
    > > --- linux-2.6.git.orig/include/linux/fs.h
    > > +++ linux-2.6.git/include/linux/fs.h
    > > @@ -1517,6 +1517,8 @@ struct block_device_operations;
    > > #define HAVE_COMPAT_IOCTL 1
    > > #define HAVE_UNLOCKED_IOCTL 1
    > >
    > > +struct seq_file;
    > > +
    >
    > We already have a forward declaration of seq_file in fs.h. At line
    > 1583(!).
    >
    > This is why forward declarations should always be placed at the start
    > of the file, please.

    Yes, thanks a lot, Andrew!

    Cyrill


    \
     
     \ /
      Last update: 2012-11-13 08:41    [W:3.366 / U:1.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site