Messages in this thread | | | Subject | Re: [PATCH 3/3] PM: Introduce Intel PowerClamp Driver | From | Joe Perches <> | Date | Mon, 12 Nov 2012 22:33:36 -0800 |
| |
On Mon, 2012-11-12 at 14:03 -0800, Jacob Pan wrote: > Intel PowerClamp driver performs synchronized idle injection across > all online CPUs. The goal is to maintain a given package level C-state > ratio.
style trivia:
[]
> diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c [] > + > +/* #define DEBUG */ > +
Adding this #define before any #include
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +#include <linux/module.h> > +#include <linux/kernel.h>
[]
> +static int window_size_set(const char *arg, const struct kernel_param *kp) > +{ [] > + if (new_window_size >= 10 || new_window_size < 2) { > + pr_err("PowerClamp: invalid window size %lu, between 2-10\n", > + new_window_size);
Means there's no need for "PowerClamp: " prefixes with pr_fmt
pr_err("invalid window size %lu...
and all the other pr_<level> uses get prefixed too.
> +static u64 pkg_state_counter(void) > +{ > + u64 val; > + u64 count = 0; > + > + static int skip_c2; > + static int skip_c3; > + static int skip_c6; > + static int skip_c7;
bool?
| |