Messages in this thread | | | Date | Tue, 13 Nov 2012 11:24:20 +1100 | From | Dave Chinner <> | Subject | Re: xfs: Use bool type rather than a custom boolean_t type. |
| |
On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote: > Hi, > > Please, take a look. > > Patch attached.
It's a good start for a cleanup, but there's no point in removing the boolean_t from one file and then not removing it from the rest of the XFS code. It's only used in a handful of places, so just remove it completely.
Also, can you please place patches in line rather than attaching them. Attaching them means they cannot be quoted in reply. See Documentation/SubmittingPatches and Documentation/email-clients.txt for guidelines.
Cheers,
Dave.
-- Dave Chinner david@fromorbit.com
| |