lkml.org 
[lkml]   [2012]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Bisected regression: iterate_fd() selinux change affects flash plugin
Quoting Eric Paris <eparis@parisplace.org>:

> OMG this +1 -1 stuff is nuts...
>
> iterate_fd passes fd+1 instead of the fd for the file? seriously?
> ewwww. I see how this patch fixes it, but still, wouldn't some magic
> or negative value for no entries found be better than having to
> understand the crazy logics?

I agree. -ENOENT is both magic and negative :)

I tend to think now that iterate_fd() should be rewritten before it's too
late and all its current users should be cross-checked against the
code prior to the introduction of iterate_fd().

--
Regards,
Pavel Roskin


\
 
 \ /
  Last update: 2012-11-12 18:41    [W:0.071 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site