On Mon, Nov 12, 2012 at 4:53 PM, Andy Shevchenko<andriy.shevchenko@linux.intel.com> wrote:> + if (!pdata && autocfg)> + pdata = &dw_dma_pdata;> +> + if (!pdata || pdata->nr_channels > DW_DMA_MAX_NR_CHANNELS)> + return -EINVAL;> +Another thing: replace the second if with else if :)