Messages in this thread Patch in this message | | | Date | Mon, 12 Nov 2012 14:08:14 +0300 | From | Dan Carpenter <> | Subject | [patch] fbmem: return -EFAULT on copy_to_user() failure |
| |
copy_to_user() returns the number of bytes remaining to be copied. put_user() returns -EFAULT on error.
This function ORs a bunch of stuff together and returns jumbled non-zero values on error. It should return -EFAULT.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c index 3ff0105..3d2a4d0 100644 --- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c @@ -1302,8 +1302,9 @@ static int do_fscreeninfo_to_user(struct fb_fix_screeninfo *fix, err |= put_user(fix->accel, &fix32->accel); err |= copy_to_user(fix32->reserved, fix->reserved, sizeof(fix->reserved)); - - return err; + if (err) + return -EFAULT; + return 0; } static int fb_get_fscreeninfo(struct fb_info *info, unsigned int cmd,
| |