lkml.org 
[lkml]   [2012]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] cgroup: deactivate CSS's and mark cgroup dead before invoking ->pre_destroy()
On Wed 31-10-12 14:27:25, Tejun Heo wrote:
> Hey, Michal.
>
> On Wed, Oct 31, 2012 at 10:23:59PM +0100, Michal Hocko wrote:
> > > + for_each_subsys(cgrp->root, ss)
> > > + if (ss->pre_destroy)
> > > + WARN_ON_ONCE(ss->pre_destroy(cgrp));
> >
> > Do you think that BUG_ON would be too harsh?
>
> Yeah, I do think so. In general, I think the consensus now is to
> prefer WARN_ON[_ONCE]() over BUG_ON() whenever possible. It's not
> like we can get more information from BUG_ON()s (more likely to get
> less reporting actually by taking down the machine). Limping machines
> are better than dead ones and there just isn't much to gain here by
> killing it.

Fair enough

--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2012-11-01 10:41    [W:1.561 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site