Messages in this thread | | | Date | Thu, 1 Nov 2012 10:26:28 -0400 | From | chas williams - CONTRACTOR <> | Subject | Re: [PATCH v2 2/3] pppoatm: fix race condition with destroying of vcc |
| |
On Wed, 31 Oct 2012 23:04:35 +0100 Krzysztof Mazur <krzysiek@podlesie.net> wrote:
> There are also some minor potential issues in pppoatm driver: > > - locking issues, but now only between pppoatm_send() and > vcc_sendmsg() and maybe some other functions,
these have been around for a while. i agree that something should be done about it. just not sure what should be synchronizing this mess.
> - missing check for SS_CONNECTED in pppoatm_ioctl,
in practice you will never run into this because a pvc is immediately put into SS_CONNECTED mode (right before the userspace open() returns). however, should it check? yes. i dont see anything preventing you from running ppp on svc's.
| |