Messages in this thread | | | From | Michael Kerrisk <> | Date | Tue, 9 Oct 2012 23:54:55 +0200 | Subject | Re: [PATCH 1/4] module: add syscall to load module from fd |
| |
Kees,
> +SYSCALL_DEFINE2(finit_module, int, fd, const char __user *, uargs)
Given the repeated experience of the last few years--new system calls that are in essence revisions of older system calls with a 'flags' argument bolted on to allow more flexible behavior (e.g., accept4(), dup3(), utimensat(), epoll_create1(), pipe2(), inotify_init(1), and so on.)--maybe it is worth considering adding a 'flags' bit mask argument[1] to the finti_module() system call now, to allow for possible future extensions to the behavior of the interface. What do you think?
Thanks,
Michael
[1] Yes, I know that init_module() doesn't have a flags argument, but that interface was added when we'd seen fewer of the kinds of cases listed above.
| |