Messages in this thread | | | Date | Mon, 8 Oct 2012 10:31:33 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization |
| |
I found only 15 uses of I2C_MSG_OP, out of 653 uses of one of the three macros. Since I2C_MSG_OP has the complete set of flags, I think it should be OK?
One of the uses, in drivers/media/i2c/adv7604.c, is as follows:
struct i2c_msg msg[2] = { { client->addr, 0, 1, msgbuf0 }, { client->addr, 0 | I2C_M_RD, len, msgbuf1 }
I'm not sure what was intended, but I guess the second structure is supposed to only do a read?
julia
| |