lkml.org 
[lkml]   [2012]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ 29/52] xHCI: add aborting command ring function
On Sun, Oct 07, 2012 at 02:02:08AM +0100, Ben Hutchings wrote:
> On Thu, 2012-10-04 at 14:21 -0700, Greg Kroah-Hartman wrote:
> [...]
> > --- a/drivers/usb/host/xhci.c
> > +++ b/drivers/usb/host/xhci.c
> > @@ -52,7 +52,7 @@ MODULE_PARM_DESC(link_quirk, "Don't clea
> > * handshake done). There are two failure modes: "usec" have passed (major
> > * hardware flakeout), or the register reads as all-ones (hardware removed).
> > */
> > -static int handshake(struct xhci_hcd *xhci, void __iomem *ptr,
> > +int handshake(struct xhci_hcd *xhci, void __iomem *ptr,
> > u32 mask, u32 done, int usec)
> > {
> > u32 result;
> [...]
>
> I don't think it matters for stable, but since this function is now
> extern it should have an 'xhci_' prefix.

Is it a non-issue? I know several other drivers have a handshake
function, including the EHCI driver. If both xHCI and EHCI is built-in,
will the EHCI driver compile? I'll have to double check this...

Thanks for catching this!

Sarah Sharp


\
 
 \ /
  Last update: 2012-10-08 23:21    [W:0.200 / U:13.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site