lkml.org 
[lkml]   [2012]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 10/16] f2fs: add core inode operations
Changman Lee <cm224.lee@gmail.com> writes:
>> > +void update_inode(struct inode *inode, struct page *node_page)
>> > +{
>> > +     struct f2fs_node *rn;
>> > +     struct f2fs_inode *ri;
>> > +
>> > +     wait_on_page_writeback(node_page);
>> > +
>> > +     rn = page_address(node_page);
>> > +     ri = &(rn->i);
>> > +
>> > +     ri->i_mode = cpu_to_le16(inode->i_mode);
>> > +     ri->i_uid = cpu_to_le32(inode->i_uid);
>> > +     ri->i_gid = cpu_to_le32(inode->i_gid);
>> And make this:
>>         i_uid_write(inode, le32_to_cpu(ri->i_uid));
>>         i_gid_write(inode, le32_to_cpu(ri->i_gid));
>>
>
> You mean this. Right? :)
> ri->i_uid = cpu_to_le32(i_uid_read(inode));
> ri->i_gid = cpu_to_le32(i_gid_read(inode));

Yeah. ;)

I did have that one backwards.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-10-08 19:01    [W:0.047 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site