Messages in this thread | | | Date | Sun, 7 Oct 2012 21:16:27 +0200 | From | Oleg Nesterov <> | Subject | Re: [regression] boot failure on alpha, bisected |
| |
On 10/07, Thorsten Kranzkowski wrote: > > On Sun, Oct 07, 2012 at 07:13:00PM +0200, Oleg Nesterov wrote: > > On 10/07, Oleg Nesterov wrote: > > > > > > Hmm. I know nothing about arch/alpha and I can't understand its entry.S. > > > But _it seems_ to me that do_notify_resume() is called with irqs disabled. > > > If this is true, then imho arch/alpha should be fixed. > > > > > > Before this commit task_work_run() enabled irqs, but this was the "side > > > effect" of spin_lock_irq/spin_unlock_irq, we should not rely on this. > > > > Could you please test the debugging patch below? > > Of course. With that patch applied the kernel (ac3d0da) boots again. The trace line > is printed about once a second, with values '2' and '4'.
Thanks a lot Thorsten!
So I'll probably send the patch which enables interrupts in task_work_run(). I guess this needs "if (irqs_disabled())" for lockdep.
The question is, should I add the warning to remind that this arch needs a fix?
Oleg.
| |