Messages in this thread Patch in this message | | | From | Rusty Russell <> | Subject | Re: virtio build breakage. | Date | Sat, 06 Oct 2012 17:04:31 +0930 |
| |
Dave Jones <davej@redhat.com> writes:
> After linking, I see this.. > > ERROR: "virtqueue_kick" [net/9p/9pnet_virtio.ko] undefined! > ERROR: "virtqueue_get_buf" [net/9p/9pnet_virtio.ko] undefined!
Cool!
Someone else spotted this recently, and the fix is in my recent pull request to Linus:
commit 04679f34c141a0591e525d392929efc249440a7c Author: Michael S. Tsirkin <mst@redhat.com> Date: Fri Sep 28 15:05:14 2012 +0930
virtio-balloon: dependency fix
Devices should depend on virtio, not select it. It's supposed to be selected by the particular driver, e.g. VIRTIO_PCI. Make balloon depend on VIRTIO and EXPERIMENTAL (to match description).
Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index f38b17a..271be80 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -27,8 +27,7 @@ config VIRTIO_PCI config VIRTIO_BALLOON tristate "Virtio balloon driver (EXPERIMENTAL)" - select VIRTIO - select VIRTIO_RING + depends on EXPERIMENTAL && VIRTIO ---help--- This driver supports increasing and decreasing the amount of memory within a KVM guest.
| |