Messages in this thread | | | From | KOSAKI Motohiro <> | Date | Thu, 4 Oct 2012 17:31:26 -0400 | Subject | Re: [PATCH 2/4] acpi,memory-hotplug : rename remove_memory() to offline_memory() |
| |
On Wed, Oct 3, 2012 at 6:02 AM, Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> wrote: > From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> > > add_memory() hot adds a physical memory. But remove_memory does not > hot remove a phsical memory. It only offlines memory. The name > confuse us. > > So the patch renames remove_memory() to offline_memory(). We will > use rename_memory() for hot removing memory. > > CC: David Rientjes <rientjes@google.com> > CC: Jiang Liu <liuj97@gmail.com> > CC: Len Brown <len.brown@intel.com> > CC: Christoph Lameter <cl@linux.com> > Cc: Minchan Kim <minchan.kim@gmail.com> > CC: Andrew Morton <akpm@linux-foundation.org> > CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> > --- > drivers/acpi/acpi_memhotplug.c | 2 +- > include/linux/memory_hotplug.h | 2 +- > mm/memory_hotplug.c | 6 +++--- > 3 files changed, 5 insertions(+), 5 deletions(-)
Probably, the better way is to just remove remove_memory() and use offline_pages().
btw, current remove_memory() pfn calculation is just buggy.
> int remove_memory(u64 start, u64 size) > { > unsigned long start_pfn, end_pfn; > > start_pfn = PFN_DOWN(start); > end_pfn = start_pfn + PFN_DOWN(size);
It should be:
start_pfn = PFN_DOWN(start); end_pfn = PFN_UP(start + size)
or
start_pfn = PFN_UP(start); end_pfn = PFN_DOWN(start + size)
| |