Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [RFC/PATCHSET 00/15] perf report: Add support to accumulate hist periods | Date | Wed, 31 Oct 2012 16:24:27 +0900 |
| |
On Tue, 30 Oct 2012 10:01:10 +0100, Ingo Molnar wrote: > * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > >> On Tue, 2012-10-30 at 15:59 +0900, Namhyung Kim wrote: > >> > Yes, the callchain part needs to be improved. Peter's idea >> > indeed looks good to me too. >> >> FWIW, I think this is exactly what sysprof does, except that >> tool isn't usable for other reasons.. You might want to look >> at it though. > > I always found the fundamental sysprof system-wide call graph > profiling output/view superior - and so do many Xorg developers > who are using SysProf that I talked to - so I'd strongly > encourage to use that ordering and grouping for the default perf > call-graph profiling output/view.
Okay, I'll look at the sysprof.
Anyway, do you have any other comments for the general --cumulate approach in this series (esp. with --branch-stack)?
Thanks, Namhyung
| |