Messages in this thread | | | From | "Liu, Chuansheng" <> | Subject | RE: [PATCH 1/3] alarmtimer: Replace the spinlock rtcdev_lock with mutex | Date | Thu, 1 Nov 2012 00:02:13 +0000 |
| |
> -----Original Message----- > From: Oliver Neukum [mailto:oneukum@suse.de] > Sent: Wednesday, October 31, 2012 5:03 PM > To: Liu, Chuansheng > Cc: john.stultz@linaro.org; tglx@linutronix.de; gregkh@linuxfoundation.org; > linux-kernel@vger.kernel.org; Liu, Chuansheng > Subject: Re: [PATCH 1/3] alarmtimer: Replace the spinlock rtcdev_lock with > mutex > > On Thursday 01 November 2012 00:20:55 Chuansheng Liu wrote: > > When do code reviewing, found no special requirement to > > use spin_lock_irqsave/spin_unlock_irqrestore, because > > alarmtimer_get_rtcdev() is called by posix clock interface. > > So would like to use mutex to replace it. > > What is gained thereby? spin_lock_irqsave will disable the preempt and local irq, it is expensive than mutex. Thanks. > > Regards > Oliver
| |