Messages in this thread |  | | Date | Wed, 31 Oct 2012 05:49:44 +0000 (UTC) | | From | Paul Walmsley <> | | Subject | RE: [PATCH] omap2-clk: Add missing lcdc clock definition |
| |
On Wed, 31 Oct 2012, Hiremath, Vaibhav wrote:
> As far as lck clock node is concerned, we had deliberately dropped all leaf- > node clocks from the clock tree, please refer to the description mentioned > in - > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-May/101987.html
Ach, should have remembered that :-( Indeed there is an LCDC hwmod:
static struct omap_hwmod am33xx_lcdc_hwmod = { .name = "lcdc", .class = &am33xx_lcdc_hwmod_class, .clkdm_name = "lcdc_clkdm", .mpu_irqs = am33xx_lcdc_irqs, .flags = HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY, .main_clk = "lcd_gclk", .prcm = { .omap4 = { .clkctrl_offs = AM33XX_CM_PER_LCDC_CLKCTRL_OFFSET, .modulemode = MODULEMODE_SWCTRL, }, }, };
> >From LCDC driver perspective, driver is using, > > fb_clk = clk_get(&device->dev, NULL); > > This I feel needs to be corrected for valid name as per Spec (mostly I would > vote for "fck") and then every platform should make sure that it returns > valid clock-node for it. > > Change in Driver would be, > > fb_clk = clk_get(&device->dev, "fck");
Indeed.
- Paul
|  |