lkml.org 
[lkml]   [2012]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/9] rcu: use this_cpu_ptr per-cpu helper instead of per_cpu_ptr(p, raw_smp_processor_id())
On Wed, Oct 31, 2012 at 09:20:19PM +0800, Shan Wei wrote:
> Paul E. McKenney said, at 2012/10/31 19:51:
> >
> > The first uses smp_processor_id(), which will complain if
> > force_quiescent_state() is called with preemption disabled, which it
> > sometimes is.
> >
> > So what am I missing here?
>
> Hi Paul
>
> this patch is not right for CONFIG_DEBUG_PREEMPT case.
> __this_cpu_ptr is ok which do not check for preemption context.

Ah, got it. Please feel free to submit an updated patch.

Thanx, Paul



\
 
 \ /
  Last update: 2012-10-31 15:01    [W:0.292 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site