lkml.org 
[lkml]   [2012]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: hid-sensors: convert HID_SENSOR_ENUM_BASE_QUIRKS to bool
On 10/22/2012 08:57 AM, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>
> It's non-sense to use tristate for the option, it's bool.
>
Good point.

Applied to fixes-togreg branch of

git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git

Thanks,

Jonathan

> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> drivers/iio/common/hid-sensors/Kconfig | 2 +-
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 6 ++----
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/common/hid-sensors/Kconfig b/drivers/iio/common/hid-sensors/Kconfig
> index 8e63d81..ae10778 100644
> --- a/drivers/iio/common/hid-sensors/Kconfig
> +++ b/drivers/iio/common/hid-sensors/Kconfig
> @@ -15,7 +15,7 @@ config HID_SENSOR_IIO_COMMON
> attributes.
>
> config HID_SENSOR_ENUM_BASE_QUIRKS
> - tristate "ENUM base quirks for HID Sensor IIO drivers"
> + bool "ENUM base quirks for HID Sensor IIO drivers"
> depends on HID_SENSOR_IIO_COMMON
> help
> Say yes here to build support for sensor hub FW using
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index d4b790d..d60198a 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -36,10 +36,8 @@ static int hid_sensor_data_rdy_trigger_set_state(struct iio_trigger *trig,
> int state_val;
>
> state_val = state ? 1 : 0;
> -#if (defined CONFIG_HID_SENSOR_ENUM_BASE_QUIRKS) || \
> - (defined CONFIG_HID_SENSOR_ENUM_BASE_QUIRKS_MODULE)
> - ++state_val;
> -#endif
> + if (IS_ENABLED(CONFIG_HID_SENSOR_ENUM_BASE_QUIRKS))
> + ++state_val;
> st->data_ready = state;
> sensor_hub_set_feature(st->hsdev, st->power_state.report_id,
> st->power_state.index,
>


\
 
 \ /
  Last update: 2012-10-31 12:41    [W:0.035 / U:1.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site