Messages in this thread | | | Date | Wed, 3 Oct 2012 16:37:30 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v5 1/2] hwmon: (ads7828) driver cleanup |
| |
On Wed, Oct 03, 2012 at 04:54:07PM -0400, Vivien Didelot wrote: > As there is no reliable way to identify the chip, it is preferable to > remove the detect callback, to avoid misdetection. > > Module parameters are not worth it here, so let's get rid of them and > add an ads7828_platform_data structure instead. > > Clean the code by removing unused macros, fixing coding style issues, > avoiding function prototypes and using convenient macros such as > module_i2c_driver(). > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied to -next.
Thanks, Guenter
| |