Messages in this thread | | | Date | Wed, 3 Oct 2012 11:21:19 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] slub: init_kmem_cache_cpus() and put_cpu_partial() can be static |
| |
On Wed, 3 Oct 2012, Christoph Lameter wrote:
> > > Acked-by: Glauber Costa <glommer@parallels.com> > > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > > > Acked-by: David Rientjes <rientjes@google.com> > > > > I think init_kmem_cache_cpus() would also benefit from just being inlined > > into alloc_kmem_cache_cpus(). > > The compiler will do that if it is advantageous. >
Which it obviously does with -O2, but I think it would be advantageous to do this at the source code level as well since we have a function with a single caller, which happens to be marked inline itself, but we're not inline. It seems cleaner to me, but it's only a suggestion. Thanks.
| |