lkml.org 
[lkml]   [2012]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code
    Date
    From: Peter Senna Tschudin <peter.senna@gmail.com>

    Convert a nonnegative error return code to a negative one, as returned
    elsewhere in the function.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    (
    if@p1 (\(ret < 0\|ret != 0\))
    { ... return ret; }
    |
    ret@p1 = 0
    )
    ... when != ret = e1
    when != &ret
    *if(...)
    {
    ... when != ret = e2
    when forall
    return ret;
    }
    // </smpl>

    Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>

    ---
    drivers/net/ethernet/marvell/skge.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
    index 5a30bf8..91836b5 100644
    --- a/drivers/net/ethernet/marvell/skge.c
    +++ b/drivers/net/ethernet/marvell/skge.c
    @@ -3945,8 +3945,10 @@ static int __devinit skge_probe(struct pci_dev *pdev,
    skge_board_name(hw), hw->chip_rev);

    dev = skge_devinit(hw, 0, using_dac);
    - if (!dev)
    + if (!dev) {
    + err = -ENOMEM;
    goto err_out_led_off;
    + }

    /* Some motherboards are broken and has zero in ROM. */
    if (!is_valid_ether_addr(dev->dev_addr))


    \
     
     \ /
      Last update: 2012-10-03 19:01    [W:2.987 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site