Messages in this thread | | | Subject | Re: [PATCH 7/10] compiler{,-gcc4}.h: Introduce __flatten function attribute | From | Steven Rostedt <> | Date | Wed, 03 Oct 2012 11:14:01 -0400 |
| |
On Wed, 2012-10-03 at 09:46 -0500, Daniel Santos wrote:
> > Please move the patch to the patch series where it is used. Otherwise it > > confuses reviewers as it did here. > Ok then, but this would also apply to the addition of these macros as well: > BUILD_BUG_ON_NON_CONST > BUILD_BUG42 > BUILD_BUG_ON_NON_CONST42 > > Should these then also be moved?
If they are only used by the other patch set, sure.
> Should I only CC those who have responded to these patches and whomever > is in the MAINTAINERS file then?
Yep. I personally never use the get_maintainers script. I first check the MAINTAINERS file. If the subsystem I'm working on exists there, I only email those that are listed there, including any mailing lists that are mentioned (as well as LKML). If it's not listed, I then do a git log and see who does the most sign offs to changes there, and to what kind of changes. I usually ignore the trivial stuff.
-- Steve
| |