Messages in this thread Patch in this message | | | Date | Wed, 03 Oct 2012 15:42:15 +0200 | From | Claudio Scordino <> | Subject | [PATCH] umc-bus.c: fix usage of device_trylock |
| |
Hi all.
I've probably found a wrong usage of device_trylock inside the driver umc-bus.c: device_trylock has the same semantics of mutex_trylock, so it returns 1 if the lock has been acquired successfully.
Please, find below a patch.
Best regards,
Claudio
Subject: umc-bus.c: fix usage of device_trylock From: Claudio Scordino <claudio@evidence.eu.com>
device_trylock has the same semantics of mutex_trylock, so it returns 1 if the lock has been acquired successfully.
Signed-off-by: Claudio Scordino <claudio@evidence.eu.com> --- drivers/uwb/umc-bus.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/uwb/umc-bus.c b/drivers/uwb/umc-bus.c index 82a84d5..5c5b3fc 100644 --- a/drivers/uwb/umc-bus.c +++ b/drivers/uwb/umc-bus.c @@ -63,7 +63,7 @@ int umc_controller_reset(struct umc_dev *umc) struct device *parent = umc->dev.parent; int ret = 0; - if (device_trylock(parent)) + if (!device_trylock(parent)) return -EAGAIN; ret = device_for_each_child(parent, parent, umc_bus_pre_reset_helper); if (ret >= 0) -- 1.7.1
| |