Messages in this thread | | | Date | Mon, 29 Oct 2012 18:58:33 +0530 | From | Ananth N Mavinakayanahalli <> | Subject | Re: [PATCH 1/4] uprobes/powerpc: Don't clear TIF_UPROBE in do_notify_resume() |
| |
On Mon, Oct 29, 2012 at 01:43:25PM +0100, Oleg Nesterov wrote: > On 10/29, Ananth N Mavinakayanahalli wrote: > > > > On Sun, Oct 28, 2012 at 06:39:25PM +0100, Oleg Nesterov wrote: > > > > Hi Oleg, > > > > > Cleanup. No need to clear TIF_UPROBE, do_notify_resume() does this. > > > > > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > > > --- > > > arch/powerpc/kernel/signal.c | 4 +--- > > > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c > > > index a2dc757..3b99711 100644 > > > --- a/arch/powerpc/kernel/signal.c > > > +++ b/arch/powerpc/kernel/signal.c > > > @@ -158,10 +158,8 @@ static int do_signal(struct pt_regs *regs) > > > > > > void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags) > > > > But this _is_ do_notify_resume()... > > Argh. I'll fix the changelog, see v2 below. > > > I don't see this flag cleared > > anywhere else. > > > > Did you have something else in mind? > > Sorry for confusion. > > As Srikar explained, it is cleared by uprobe_notify_resume(). See db023ea5 > "uprobes: Move clear_thread_flag(TIF_UPROBE) to uprobe_notify_resume()", it > is already in Linus's tree.
I was looking at rc2.. that explains it.
> Oleg. > > ------------------------------------------------------------------------------ > Subject: [PATCH 1/4] uprobes/powerpc: Don't clear TIF_UPROBE in do_notify_resume() > > Cleanup. No need to clear TIF_UPROBE, uprobe_notify_resume() does this. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Thanks Oleg!
Ananth
| |