Messages in this thread Patch in this message |  | | From | Yan Hong <> | | Subject | [PATCH 2/5] debugfs: return directly if failed to allocate memory in debug_fill_super() | | Date | Sat, 27 Oct 2012 16:05:26 +0800 |
| |
If kzalloc failed, memory is not allocated, sb->s_fs_info is NULL. No need to go through clean up code, return -ENOMEM directly.
Signed-off-by: Yan Hong <clouds.yan@gmail.com> --- fs/debugfs/inode.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index b607d92..11f6514 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -262,10 +262,8 @@ static int debug_fill_super(struct super_block *sb, void *data, int silent) fsi = kzalloc(sizeof(struct debugfs_fs_info), GFP_KERNEL); sb->s_fs_info = fsi; - if (!fsi) { - err = -ENOMEM; - goto fail; - } + if (!fsi) + return -ENOMEM; err = debugfs_parse_options(data, &fsi->mount_opts); if (err) -- 1.7.9.5
|  |