lkml.org 
[lkml]   [2012]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 26/31] sched, numa, mm: Add fault driven placement and migration policy

* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Fri, 2012-10-26 at 15:50 +0200, Ingo Molnar wrote:
> >
> > Oh, just found the reason:
> >
> > the ptep_modify_prot_start()/modify()/commit() sequence is
> > SMP-unsafe - it has to be done under the mmap_sem
> > write-locked.
> >
> > It is safe against *hardware* updates to the PTE, but not
> > safe against itself.
>
> Shouldn't the pte_lock serialize all that still? All sites
> that modify PTE contents should hold the pte_lock (and do
> afaict).

Hm, indeed.

Is there no code under down_read() (in the page fault path) that
modifies the pte via just pure atomics?

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-10-26 17:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog