Messages in this thread | | | Date | Fri, 26 Oct 2012 13:43:10 +0800 | From | Tang Chen <> | Subject | Re: [PATCH v2 2/2] Improve container_notify_cb() to support container hot-remove. |
| |
Hi Toshi,
On 10/26/2012 01:20 AM, Toshi Kani wrote: ... >>>> Why do you need to call acpi_bus_trim(device,0) to stop the container >>>> device first? >>> >>> This issue was introduced by Lu Yinghai, I think he could give a better >>> answer than me. :) >>> Please refer to the following url: >>> >>> http://www.spinics.net/lists/linux-pci/msg17667.html >>> >>> However, this is not applied into the pci tree yet. >> We have worked out a patch set to clean up the logic for PCI/ACPI binding >> relationship. It updates PCI/ACPI binding relationship by registering bus >> notification onto pci_bus_type instead of hooking into the ACPI/glue.c. > > Thanks for the info and pointer. Tang, I'd suggest you add such info to > the comment so that others know that this step is needed for removing > PCI bridges. It helps us to know where to look at...
OK, I'll add it in the next version. :)
> >> To accommodate that patch set, the ACPI device destroy process has been >> split into two steps: >> 1) acpi_bus_trim(device,0) to unbind ACPI drivers > > Does this step also detach PCI drivers from PCI cards as well?
Yes, it calls device_release_driver() to release the device driver.
device_release_driver() |->__device_release_driver() |->dev->driver = NULL;
Thanks. :)
> > Thanks, > -Toshi > >
| |