Messages in this thread | | | Date | Wed, 24 Oct 2012 15:57:31 -0700 | From | Dave Hansen <> | Subject | Re: [PATCH] add some drop_caches documentation and info messsge |
| |
On 10/24/2012 03:48 PM, Borislav Petkov wrote: > On Wed, Oct 24, 2012 at 02:18:38PM -0700, Dave Hansen wrote: >> Sounds fairly valid to me. But, it's also one that would not be harmed >> or disrupted in any way because of a single additional printk() during >> each suspend-to-disk operation. > > back to the drop_caches patch. How about we hide the drop_caches > interface behind some mm debugging option in "Kernel Hacking"? Assuming > we don't need it otherwise on production kernels. Probably make it > depend on CONFIG_DEBUG_VM like CONFIG_DEBUG_VM_RB or so. > > And then also add it to /proc/vmstat, in addition.
That effectively means removing it from the kernel since distros ship with those config options off. We don't want to do that since there _are_ valid, occasional uses like benchmarking that we want to be consistent.
| |