lkml.org 
[lkml]   [2012]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: linux-next: build failure after merge of the akpm tree
From
Date
On Tue, 2012-10-23 at 13:02 -0700, Andrew Morton wrote:
> On Tue, 23 Oct 2012 12:51:29 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > > btw, what's up with printk_syslog.h? It includes two header files which it
> > > doesn't need but fails to include the two it *does* need: printk_log.h
> > > and types.h.
> > >
> > >
> >
> > printk_syslog.c includes kernel.h (it includes types.h)
> > and printk_log.h.
> >
> > I think printk_syslog.h doesn't need printk_log.h
>
> A general rule is that the header file shouldn't know or care what else
> it's includer has included. Ideally it shouldn't know or care what
> else its includees have included, either.
>
> A fun test would be
>
> for i in *.h
> echo $i > foo.c
> make foo.o
> done

A whole lot of things in include/ fail this.

Do you really think that anything using u8/16/32/64
should include types.h?




\
 
 \ /
  Last update: 2012-10-24 23:01    [W:0.050 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site