lkml.org 
[lkml]   [2012]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] aoe: avoid using skb member after dev_queue_xmit
From
Date
After calling dev_queue_xmit it is no longer safe to access the
members of the skb.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ed Cashin <ecashin@coraid.com>
---
drivers/block/aoe/aoenet.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoenet.c
index ae56828..2e47404 100644
--- a/drivers/block/aoe/aoenet.c
+++ b/drivers/block/aoe/aoenet.c
@@ -55,12 +55,14 @@ static int
tx(void) __must_hold(&txlock)
{
struct sk_buff *skb;
+ struct net_device *ifp;

while ((skb = skb_dequeue(&skbtxq))) {
spin_unlock_irq(&txlock);
+ ifp = skb->dev;
if (dev_queue_xmit(skb) == NET_XMIT_DROP && net_ratelimit())
pr_warn("aoe: packet could not be sent on %s. %s\n",
- skb->dev ? skb->dev->name : "netif",
+ ifp ? ifp->name : "netif",
"consider increasing tx_queue_len");
spin_lock_irq(&txlock);
}
--
1.7.1


\
 
 \ /
  Last update: 2012-10-24 21:01    [W:0.058 / U:2.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site