lkml.org 
[lkml]   [2012]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: gadget: ncm: correct endianess conversion
On Mon, Oct 08, 2012 at 11:59:03PM +0300, Dmytro Milinevskyy wrote:
> Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver.
> Tested on MIPS32 big-endian device.
>
> Signed-off-by: Dmytro Milinevskyy <milinevskyy@gmail.com>
> ---
> drivers/usb/gadget/f_ncm.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c
> index b651b52..fce45ab 100644
> --- a/drivers/usb/gadget/f_ncm.c
> +++ b/drivers/usb/gadget/f_ncm.c
> @@ -869,11 +869,11 @@ static struct sk_buff *ncm_wrap_ntb(struct gether *port,
> struct sk_buff *skb2;
> int ncb_len = 0;
> __le16 *tmp;
> - int div = ntb_parameters.wNdpInDivisor;
> - int rem = ntb_parameters.wNdpInPayloadRemainder;
> - int pad;
> - int ndp_align = ntb_parameters.wNdpInAlignment;
> - int ndp_pad;
> + int div = le16_to_cpu(ntb_parameters.wNdpInDivisor);
> + int rem = le16_to_cpu(ntb_parameters.wNdpInPayloadRemainder);
> + int pad;
> + int ndp_align = le16_to_cpu(ntb_parameters.wNdpInAlignment);
> + int ndp_pad;

It would be nice to keep the two tabs between int and variable. One question:
In ntb_parameters the member wLength is 16bit and not using cpu_to_le16(). How
does it work? Is the test on host side not strict enough?

> unsigned max_size = ncm->port.fixed_in_len;
> struct ndp_parser_opts *opts = ncm->parser_opts;
> unsigned crc_len = ncm->is_crc ? sizeof(uint32_t) : 0;

Sebastian


\
 
 \ /
  Last update: 2012-10-24 16:41    [W:0.072 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site