Messages in this thread | | | Date | Wed, 24 Oct 2012 07:39:45 +0200 | Subject | Re: [RFC PATCH] gpiolib: add gpio get direction support | From | Linus Walleij <> |
| |
On Tue, Oct 23, 2012 at 1:06 PM, Mathias Nyman <mathias.nyman@linux.intel.com> wrote: > [Me] >> Anyway, if the callback is only called internally in the GPIOlib >> why are you making the function public to the entire >> kernel > > Thought I'd do it the same was as gpio_direction_output() and > gpio_direction_input(), but if there is no need for getting the direction > outside gpiolob then it can be skipped. Main motivation was to get correct > direction values in debug and sysfs after boot.
OK then keep them static til the day they are needed.
> gpiolib currently uses cached values of gpio_direction_output/input() in > sysfs. If the .get_direction callback exists it is used to refresh the > cached values.
OK! (I'm not yet familiar enough with gpiolib as you can see ...)
Yours, Linus Walleij
| |