lkml.org 
[lkml]   [2012]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/10] xen/hypercall: Make xen_remove_from_physmap the same on 64/32 builds.
From
Date
On Tue, 2012-10-23 at 19:12 +0100, Konrad Rzeszutek Wilk wrote:
> By making the structure exactly the same size and with the same
> offsets on 64 and 32-bit builds we are future-proofing ourselves.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> include/xen/interface/memory.h | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/include/xen/interface/memory.h b/include/xen/interface/memory.h
> index 8beebdb..6b07b54 100644
> --- a/include/xen/interface/memory.h
> +++ b/include/xen/interface/memory.h
> @@ -253,9 +253,14 @@ extern spinlock_t xen_reservation_lock;
> struct xen_remove_from_physmap {
> /* Which domain to change the mapping for. */
> domid_t domid;
> -
> + /* To be used in the future if need to. */
> + uint8_t reserved[6];
> /* GPFN of the current mapping of the page. */
> xen_pfn_t gpfn;
> +#ifdef CONFIG_X86_32
> + /* No need to do that on ARM as xen_pfn_t is always 8 bytes. */
> + uint8_t __pad[4];
> +#endif

I'm not sure if this last one is necessary since this isn't a struct
which would get used in an array. I guess it doesn't hurt though.

> };
> DEFINE_GUEST_HANDLE_STRUCT(xen_remove_from_physmap);
>




\
 
 \ /
  Last update: 2012-10-24 12:21    [W:0.460 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site