Messages in this thread | | | Date | Mon, 22 Oct 2012 14:58:47 -0700 | From | Christopher Heiny <> | Subject | Re: [RFC PATCH 02/06] input/rmi4: Core files |
| |
On 10/10/2012 08:06 PM, Joe Perches wrote: > On Thu, 2012-10-11 at 02:49 +0000, Christopher Heiny wrote: >> Joe Perches wrote: > [] >>>> + list_for_each_entry(entry, &data->rmi_functions.list, list) >>>> + if (entry->irq_mask) >>>> + process_one_interrupt(entry, irq_status, >>>> + data); >>> >>> style nit, it'd be nicer with braces. >> >> I agree with you, but checkpatch.pl doesn't. :-( > > Sure it does. > > $ cat t.c > { > list_for_each_entry(entry, &data->rmi_functions.list, list) { > if (entry->irq_mask) > process_one_interrupt(entry, irq_status, data); > } > } > $ ./scripts/checkpatch.pl --strict -f t.c > total: 0 errors, 0 warnings, 0 checks, 7 lines checked > > t.c has no obvious style problems and is ready for submission.
I stand corrected. Thanks!
| |