lkml.org 
[lkml]   [2012]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] staging: android: checkpatch.pl fixes
Date
Joe Perches <joe@perches.com> wrote:

> On Sat, 2012-10-20 at 23:33 +0100, Ken O'Brien wrote:
> ...
> > - pr_err("binder: %d: binder_alloc_buf failed to "
> > + pr_err("binder: %d: binder_alloc_buf failed to " \
> > "map pages in userspace, no vma\n", proc->pid);
> ...
> Nice try, but the "right" way to do this is to coalesce formats like:
>
> pr_err("binder: %d: binder_alloc_buf failed to map pages in userspace, no vma\n",
> proc->pid);

Surely the right way is to fix _checkpatch_ to see ["]\n\s*["] and merge the
lines before checking them? We shouldn't have to fix up the source in either
of these fashions just because checkpatch is broken.

David


\
 
 \ /
  Last update: 2012-10-22 12:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog