lkml.org 
[lkml]   [2012]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/11] perf record: Fix mmap error output condition
    Date
    The mmap_pages default value is not power of 2 (UINT_MAX).

    Together with perf_evlist__mmap function returning error value
    different from EPERM, we get misleading error message:
    "--mmap_pages/-m value must be a power of two."

    Fixing this by adding extra check for UINT_MAX value for this
    error condition.

    Signed-off-by: Jiri Olsa <jolsa@redhat.com>
    Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    ---
    tools/perf/builtin-record.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
    index 3cf7fe2..93dc67e 100644
    --- a/tools/perf/builtin-record.c
    +++ b/tools/perf/builtin-record.c
    @@ -358,7 +358,8 @@ try_again:
    "or try again with a smaller value of -m/--mmap_pages.\n"
    "(current value: %d)\n", opts->mmap_pages);
    rc = -errno;
    - } else if (!is_power_of_2(opts->mmap_pages)) {
    + } else if (!is_power_of_2(opts->mmap_pages) &&
    + (opts->mmap_pages != UINT_MAX)) {
    pr_err("--mmap_pages/-m value must be a power of two.");
    rc = -EINVAL;
    } else {
    --
    1.7.11.4


    \
     
     \ /
      Last update: 2012-10-20 17:21    [W:3.956 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site