Messages in this thread | | | Date | Mon, 1 Oct 2012 21:35:00 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2 2/2] hwmon: (ads7828) add support for ADS7830 |
| |
On Mon, Oct 01, 2012 at 11:28:21PM -0400, Vivien Didelot wrote: > Hi Guenter, > Hi Vivien,
[ ... ]
> > > + } else { > > > + dev_dbg(&client->dev, "doesn't look like an " > > > + "ADS7828 compatible device\n"); > > > > WARNING: quoted string split across lines > > #190: FILE: drivers/hwmon/ads7828.c:196: > > + dev_dbg(&client->dev, "doesn't look like an " > > + "ADS7828 compatible device\n"); > Hum ok, so the reason for that is that it breaks the ability to grep a > string... Makes sense. > > > > Better: > > dev_dbg(&client->dev, > > "doesn't look like an ADS7828 compatible device\n"); > This exceeds 80 chars, but I'll find a shorter message.
That is ok nowadays if it is due to a quoted string.
Guenter
| |