Messages in this thread | | | Date | Tue, 2 Oct 2012 18:42:21 +0200 | From | Alexander Gordeev <> | Subject | Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs |
| |
On Tue, Oct 02, 2012 at 07:09:29AM +0200, Ingo Molnar wrote: > > +irqreturn_t ahci_hw_interrupt(int irq, void *dev_instance) > > +{ > > + struct ata_port *ap_this = dev_instance; > > + struct ahci_port_priv *pp = ap_this->private_data; > > + struct ata_host *host = ap_this->host; > > + struct ahci_host_priv *hpriv = host->private_data; > > + void __iomem *mmio = hpriv->mmio; > > + unsigned int i; > > + u32 irq_stat, irq_masked; > > + > > + VPRINTK("ENTER\n"); > > Is this per IRQ handler execution debugging code still needed? > Same for the other VPRINTK() lines in this patch.
These VPRINKs are only to make new handlers look like ahci_interrupt() which did not change. I believe, if they need to go it is better to remove them altogether, with a separate followup patch.
Jeff, what do you think?
Thanks!
-- Regards, Alexander Gordeev agordeev@redhat.com
| |