Messages in this thread | | | Date | Tue, 2 Oct 2012 09:25:00 -0400 | From | Vivek Goyal <> | Subject | Re: [PATCH 02/15] cfq-iosched: More renaming to better represent wl_class and wl_type |
| |
On Mon, Oct 01, 2012 at 04:50:37PM -0400, Jeff Moyer wrote: > Vivek Goyal <vgoyal@redhat.com> writes: > > > Also at places I have got rid of keyword "serving" as it is obivious. > > I don't agree with getting rid of serving. After your patch, it looks > as though a cfqd has a static workload class and type. It reads better > to me the way it is.
It is also about the length of name. To me now a days CFQ code looks pretty messy with very long names or lines at many a places.
So yes, "cfqd->serving_wl_class" and "cfqd->serving_wl_type" is more readable than "cfqd->wl_class" and "cfqd->wl_type". But it also increases the string length significantly.
I don't know. Some of the strings seem too long and code spills into multiple lines for a single statement.
Anyway, for this I guess I will retain "serving" keyword.
Thanks Vivek
| |